Hold the OpenAPI routing to the profile that master now enforces

master turned on the strict critic profile while this branch was open.
t/TCMS.t now declares /aasx and fatal warnings like every other test, and
loads FindBin::libs instead of a hardcoded lib path.  It also checks each
close.  Fatal warnings make the single mention of %TCMS::openapi die, so the
copy turns off the once warning for that line alone.  build_routes asks
List::Util::any whether a variable already has a parameter, rather than
using grep as a boolean.  OpenAPI joins the POD stopwords.

The token test that master added called the old validator coderef.  It now
validates against the parameter's schema, and adds the case of a full uuid
followed by a newline, which perl's $ lets through.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

.pod_stopwords

@@ -230,6 +230,7 @@ NTP
 nullary
 OAuth
 OOM
+OpenAPI
 OpenAPIv
 openapiv
 overcommit

lib/TCMS.pm

@@ -8,6 +8,7 @@ use Carp  qw{confess};
 use Clone qw{clone};
 
 use CGI::Cookie ();
+use List::Util  ();
 use URI();
 
 #Grab our custom routes
@@ -211,7 +212,7 @@ sub build_routes {
 
         my @parameters = @{ $v->{parameters} // [] };
         foreach my $variable ( $k =~ m/\{([^{}]+)\}/g ) {
-            next if grep { $_->{in} eq 'path' && $_->{name} eq $variable } @parameters;
+            next if List::Util::any { $_->{in} eq 'path' && $_->{name} eq $variable } @parameters;
             push( @parameters, { name => $variable, in => 'path', required => true, schema => { type => 'string' } } );
         }
 

t/TCMS.t

@@ -4,10 +4,11 @@
 # table.
 
 use 5.040;
-use warnings;
+use re '/aasx';
+use warnings FATAL => 'all';
 
 use FindBin;
-use lib "$FindBin::Bin/../lib";
+use FindBin::libs;
 
 use Test::More;
 use Test::MockModule                   qw{strict};
@@ -34,7 +35,7 @@ BEGIN {
 
     open( my $fh, '>', "$ROOT/config/default.cfg" ) or die $!;
     print {$fh} "[general]\n    data_model=FlatFile\n    hostname=routes.test.test\n";
-    close $fh;
+    close($fh) or die $!;
 
     chdir($ROOT) or die "could not chdir to the sandbox: $!";
 }
@@ -63,7 +64,7 @@ $html->redefine( posts => sub { return [ 200, [], ['the post'] ] } );
 
 require_ok('TCMS') or BAIL_OUT("Can't load the dispatcher");
 
-my %openapi = %TCMS::openapi;
+my %openapi = do { no warnings 'once'; %TCMS::openapi };
 
 # Checked as JSON reads it, since tPSGI is not a prerequisite of tCMS: perl's
 # booleans become JSON's, and a callback becomes null.
@@ -100,7 +101,7 @@ subtest 'the routes of posts' => sub {
 
     # The flag that says setup is done, or the default route answers instead.
     open( my $fh, '>', 'config/setup' ) or die $!;
-    close $fh;
+    close($fh)                          or die $!;
     my $res = $paths->{'/posts/p-one'}{get}{'x-tpsgi-callback'}->( { log_dir => "$ROOT/logs", verbose => 0 }, { route => '/posts/p-one', dispatcher => $paths->{'/posts/p-one'}{get} } );
     is_deeply( $res->[2], ['the post'], 'and it runs the sub that the name names' );
     ok( !exists $paths->{'/posts/{curly}'}, 'but a post whose path has a brace is not, since it would be a template' );

t/Trog-Routes-JSON.t

@@ -13,15 +13,15 @@ require_ok('Trog::Routes::JSON') or BAIL_OUT("Can't find SUT");
 subtest 'the change request token is a uuid, and nothing else' => sub {
     no warnings 'once';
     my ($token) = @{ $Trog::Routes::JSON::routes{'/api/auth_change_request/{token}'}{parameters} };
-    my $jv = JSON::Validator->new->schema( $token->{schema} );
-    my $valid = sub ($value) { return !$jv->validate($value) };
+    my $jv      = JSON::Validator->new->schema( $token->{schema} );
+    my $valid   = sub ($value) { return !$jv->validate($value) };
 
-    ok( $valid->('5bed1745-4201-40dd-b5dd-65acc0316604'), 'a uuid is a token' );
-    ok( !$valid->(q{}),                                   'nothing is not' );
-    ok( !$valid->('x;drop table user'),                   'and neither is text with a hex digit in it' );
-    ok( !$valid->("5bed1745-4201\n"),                     'nor a token with something after it' );
+    ok( $valid->('5bed1745-4201-40dd-b5dd-65acc0316604'),    'a uuid is a token' );
+    ok( !$valid->(q{}),                                      'nothing is not' );
+    ok( !$valid->('x;drop table user'),                      'and neither is text with a hex digit in it' );
+    ok( !$valid->("5bed1745-4201\n"),                        'nor a token with something after it' );
     ok( !$valid->("5bed1745-4201-40dd-b5dd-65acc0316604\n"), 'nor a uuid with a newline after it' );
-    ok( !$valid->('a|b'),                                 'nor a pipe, which the class used to hold' );
+    ok( !$valid->('a|b'),                                    'nor a pipe, which the class used to hold' );
 };
 
 done_testing();