Răsfoiți Sursa

Fix documentation in binary classes

Daniel Gempesaw 11 ani în urmă
părinte
comite
422145c27b
3 a modificat fișierele cu 11 adăugiri și 22 ștergeri
  1. 1 7
      lib/Selenium/Chrome.pm
  2. 4 2
      lib/Selenium/Firefox.pm
  3. 6 13
      lib/Selenium/PhantomJS.pm

+ 1 - 7
lib/Selenium/Chrome.pm

@@ -1,6 +1,6 @@
 package Selenium::Chrome;
 package Selenium::Chrome;
 
 
-# ABSTRACT: A convenience package for creating a Chrome instance
+# ABSTRACT: Use ChromeDriver without a Selenium server
 use Moo;
 use Moo;
 use Selenium::CanStartBinary::FindBinary qw/coerce_simple_binary/;
 use Selenium::CanStartBinary::FindBinary qw/coerce_simple_binary/;
 extends 'Selenium::Remote::Driver';
 extends 'Selenium::Remote::Driver';
@@ -70,10 +70,4 @@ has 'binary_port' => (
 
 
 with 'Selenium::CanStartBinary';
 with 'Selenium::CanStartBinary';
 
 
-sub DEMOLISH {
-    my ($self) = @_;
-
-    $self->shutdown_binary;
-}
-
 1;
 1;

+ 4 - 2
lib/Selenium/Firefox.pm

@@ -1,6 +1,6 @@
 package Selenium::Firefox;
 package Selenium::Firefox;
 
 
-# ABSTRACT: A convenience package for creating a Firefox instance
+# ABSTRACT: Use FirefoxDriver without a Selenium server
 use Moo;
 use Moo;
 use Selenium::CanStartBinary::FindBinary qw/coerce_firefox_binary/;
 use Selenium::CanStartBinary::FindBinary qw/coerce_firefox_binary/;
 extends 'Selenium::Remote::Driver';
 extends 'Selenium::Remote::Driver';
@@ -38,7 +38,9 @@ has '+browser_name' => (
 =attr binary
 =attr binary
 
 
 Optional: specify the path to your binary. If you don't specify
 Optional: specify the path to your binary. If you don't specify
-anything, we'll try to find it on our own via L<File::Which/which>.
+anything, we'll try to find it on our own in the default installation
+paths for Firefox. If your Firefox is elsewhere, we probably won't be
+able to find it, so you may be well served by specifying it yourself.
 
 
 =cut
 =cut
 
 

+ 6 - 13
lib/Selenium/PhantomJS.pm

@@ -1,6 +1,6 @@
 package Selenium::PhantomJS;
 package Selenium::PhantomJS;
 
 
-# ABSTRACT: A convenience package for creating a PhantomJS instance
+# ABSTRACT: Use GhostDriver without a Selenium server
 use Moo;
 use Moo;
 use Selenium::CanStartBinary::FindBinary qw/coerce_simple_binary/;
 use Selenium::CanStartBinary::FindBinary qw/coerce_simple_binary/;
 extends 'Selenium::Remote::Driver';
 extends 'Selenium::Remote::Driver';
@@ -11,12 +11,11 @@ extends 'Selenium::Remote::Driver';
 
 
 =head1 DESCRIPTION
 =head1 DESCRIPTION
 
 
-This class allows you to use PhantomJS through Ghostdriver without
-needing the JRE or a selenium server running. When you refrain from
-passing the C<remote_server_addr> and C<port> arguments, we will
-search for the phantomjs executable binary in your $PATH. We'll try
-to start the binary connect to it, shutting it down at the end of the
-test.
+This class allows you to use PhantomJS via Ghostdriver without needing
+the JRE or a selenium server running. When you refrain from passing
+the C<remote_server_addr> and C<port> arguments, we will search for
+the phantomjs executable binary in your $PATH. We'll try to start the
+binary connect to it, shutting it down at the end of the test.
 
 
 If the binary is not found, we'll fall back to the default
 If the binary is not found, we'll fall back to the default
 L<Selenium::Remote::Driver> behavior of assuming defaults of
 L<Selenium::Remote::Driver> behavior of assuming defaults of
@@ -69,12 +68,6 @@ has 'binary_port' => (
     default => sub { 8910 }
     default => sub { 8910 }
 );
 );
 
 
-sub DEMOLISH {
-    my ($self) = @_;
-
-    $self->shutdown_binary;
-}
-
 with 'Selenium::CanStartBinary';
 with 'Selenium::CanStartBinary';
 
 
 1;
 1;