소스 검색

Consolidate binary mode attribute in builder role

Daniel Gempesaw 10 년 전
부모
커밋
4c9cfc8004
4개의 변경된 파일7개의 추가작업 그리고 20개의 파일을 삭제
  1. 6 1
      lib/Selenium/BinaryModeBuilder.pm
  2. 0 6
      lib/Selenium/Chrome.pm
  3. 1 7
      lib/Selenium/Firefox.pm
  4. 0 6
      lib/Selenium/PhantomJS.pm

+ 6 - 1
lib/Selenium/BinaryModeBuilder.pm

@@ -4,7 +4,12 @@ package Selenium::BinaryModeBuilder;
 use Selenium::Binary qw/start_binary_on_port/;
 use Try::Tiny;
 use Moo::Role;
-use namespace::clean;
+
+has 'binary_mode' => (
+    is => 'ro',
+    init_arg => undef,
+    builder => 1
+);
 
 sub _build_binary_mode {
     my ($self) = @_;

+ 0 - 6
lib/Selenium/Chrome.pm

@@ -41,12 +41,6 @@ has '+port' => (
     is => 'lazy'
 );
 
-has 'binary_mode' => (
-    is => 'ro',
-    init_arg => undef,
-    builder => 1
-);
-
 has 'binary_name' => (
     is => 'lazy',
     default => sub { 'chromedriver' }

+ 1 - 7
lib/Selenium/Firefox.pm

@@ -2,8 +2,8 @@ package Selenium::Firefox;
 
 # ABSTRACT: A convenience package for creating a Firefox instance
 use Moo;
-extends 'Selenium::Remote::Driver';
 with 'Selenium::BinaryModeBuilder';
+extends 'Selenium::Remote::Driver';
 
 =head1 SYNOPSIS
 
@@ -41,12 +41,6 @@ has '+port' => (
     default => sub { 4444 }
 );
 
-has 'binary_mode' => (
-    is => 'ro',
-    init_arg => undef,
-    builder => 1
-);
-
 has 'binary_name' => (
     is => 'lazy',
     default => sub { 'firefox' }

+ 0 - 6
lib/Selenium/PhantomJS.pm

@@ -42,12 +42,6 @@ has '+port' => (
     is => 'lazy'
 );
 
-has 'binary_mode' => (
-    is => 'ro',
-    init_arg => undef,
-    builder => 1
-);
-
 has 'binary_name' => (
     is => 'lazy',
     default => sub { 'phantomjs' }