Prechádzať zdrojové kódy

Stop testing WebElement::drag to avoid carping

Daniel Gempesaw 10 rokov pred
rodič
commit
6b3e89050f

+ 1 - 1
lib/Selenium/Remote/WebElement.pm

@@ -374,7 +374,7 @@ sub is_hidden {
 =cut
 
 sub drag {
-    carp 'drag is no longer available in the JSONWireProtocol and will be removed in the next version of this module';
+    carp 'drag is no longer available in the JSONWireProtocol.';
 }
 
 =head2 get_size

+ 0 - 7
t/02-webelement.t

@@ -91,13 +91,6 @@ IMAGES: {
     ok(defined $ret->{'y'}, 'Image - got y coord');
     my $x = $ret->{'x'};
     my $y = $ret->{'y'};
-  TODO: {
-        local $TODO = "drag doesn't appear to be working currently in selenium server";
-        $ret = $elem->drag(200,200);
-        $ret = $elem->get_element_location();
-        is($ret->{'x'}, ($x+200), 'Moved to new x coord');
-        is($ret->{'y'}, ($y+200), 'Moved to new y coord');
-    }
 }
 
 VISIBILITY: {

+ 4 - 6
t/CanStartBinary.t

@@ -9,9 +9,9 @@ use Sub::Install;
 use Test::Fatal;
 use Test::More;
 
-unless ( $ENV{RELEASE_TESTING} ) {
-    plan skip_all => "Author tests not required for installation.";
-}
+# unless ( $ENV{RELEASE_TESTING} ) {
+#     plan skip_all => "Author tests not required for installation.";
+# }
 
 PHANTOMJS: {
   SKIP: {
@@ -86,7 +86,7 @@ TIMEOUT: {
     # we can exercise the startup_timeout constructor option
     # functionality.
     Sub::Install::reinstall_sub({
-        code => sub { 0 },
+        code => sub { return 0 },
         into => 'Selenium::CanStartBinary',
         as => 'probe_port'
     });
@@ -100,8 +100,6 @@ TIMEOUT: {
 
 }
 
-
-
 sub is_proper_phantomjs_available {
     my $ver = `phantomjs --version` // '';
     chomp $ver;