瀏覽代碼

Stop checking for executable binaries on windows

It's apparently not as reliable as we thought, and it also doesn't
really seem to matter whether or not perl thinks the binary we found is
executable.
Daniel Gempesaw 10 年之前
父節點
當前提交
c6f3044934
共有 1 個文件被更改,包括 3 次插入1 次删除
  1. 3 1
      lib/Selenium/CanStartBinary/FindBinary.pm

+ 3 - 1
lib/Selenium/CanStartBinary/FindBinary.pm

@@ -11,6 +11,8 @@ require Exporter;
 our @ISA = qw/Exporter/;
 our @ISA = qw/Exporter/;
 our @EXPORT_OK = qw/coerce_simple_binary coerce_firefox_binary/;
 our @EXPORT_OK = qw/coerce_simple_binary coerce_firefox_binary/;
 
 
+use constant IS_WIN => $^O eq 'MSWin32';
+
 sub coerce_simple_binary {
 sub coerce_simple_binary {
     my ($executable) = @_;
     my ($executable) = @_;
 
 
@@ -45,7 +47,7 @@ sub _validate_manual_binary {
     };
     };
 
 
     if ( $abs_executable ) {
     if ( $abs_executable ) {
-        if ( -x $abs_executable ) {
+        if ( -x $abs_executable || IS_WIN ) {
             return $abs_executable;
             return $abs_executable;
         }
         }
         else {
         else {