Work on #303: don't use usernames in post flair

still need to fix user style names

lib/Trog/DataModule.pm

@@ -96,6 +96,8 @@ sub get ( $self, %request ) {
 
 sub _fixup ( $self, @filtered ) {
 
+    my %user2display;
+
     # urlencode spaces in filenames
     @filtered = map {
         my $subj = $_;
@@ -114,6 +116,7 @@ sub _fixup ( $self, @filtered ) {
             #XXX this needs to be correctly populated in the form?
             if ($is_user_page) {
                 my $display_name = $subj->{display_name} || Trog::Auth::username2display( $subj->{user} ) || $subj->{title};
+                $user2display{$subj->{user}} //= $display_name;
                 die "No display name for user!" unless $display_name;
                 $subj->{local_href} = "/users/$display_name";
             }
@@ -125,6 +128,12 @@ sub _fixup ( $self, @filtered ) {
 
         $subj->{method} = 'GET' unless exists( $subj->{method} );
 
+        # Grab the display name for the author if it exists
+        if ($subj->{user} && !$is_user_page) {
+            $user2display{$subj->{user}} //= Trog::Auth::username2display( $subj->{user} );
+            $subj->{display_name} = $user2display{$subj->{user}};
+        }
+
         $subj
     } @filtered;
 

www/templates/html/components/post_title.tx

@@ -14,6 +14,6 @@
         </form>
         : }
         <span id="<: $post.id :>-<: $post.version :>-time" class="responsive-hide" style="float:right;"><: $post.created :></span>
-        <a href="/users/<: $post.user :>" class='postericon <: $post.user :>' title='Posted by <: $post.user :>'>&nbsp;</a>
+        <a href="/users/<: $post.display_name :>" class='postericon <: $post.user :>' title='Posted by <: $post.display_name :>'>&nbsp;</a>
     : }
 </h3>