Преглед изворни кода

Fix #465: once more with feeling.

Don't ever use anything new in legacy modules, or you'll die.
George S. Baugh пре 4 година
родитељ
комит
6d35716851
5 измењених фајлова са 7 додато и 7 уклоњено
  1. 1 1
      t/01-driver.t
  2. 3 3
      t/02-webelement.t
  3. 1 1
      t/10-switch-to-window.t
  4. 1 1
      t/12-reuse-session.t
  5. 1 1
      t/Test-Selenium-Remote-Driver-google.t

+ 1 - 1
t/01-driver.t

@@ -135,7 +135,7 @@ GRID_STARTUP: {
     $tua->map_response(qr{(?:grid/api/hub/status|session)}, $ok);
 
     my $mock = Test::MockModule->new('Selenium::Remote::RemoteConnection');
-    $mock->redefine('check_status', sub { $grid_status_count++; 1 });
+    $mock->mock('check_status', sub { $grid_status_count++; 1 });
     my $grid_driver = Selenium::Remote::Driver->new(ua => $tua);
 
     ok(defined $grid_driver, 'Grid: Object loaded fine using grid/api/hub/status');

+ 3 - 3
t/02-webelement.t

@@ -48,14 +48,14 @@ INPUT: {
     $ret = $elem->get_tag_name();
     is($ret, 'input', 'Get tag name');
     my $selfmock = Test::MockModule->new('Selenium::Remote::WebElement');
-    $selfmock->redefine('get_tag_name',sub { 'input' });
-    $selfmock->redefine('get_property',sub { 0 });
+    $selfmock->mock('get_tag_name',sub { 'input' });
+    $selfmock->mock('get_property',sub { 0 });
 
     $elem = $driver->find_element('checky', 'id');
     $ret = $elem->is_selected();
     is($ret, 0, 'Checkbox not selected');
     $ret = $elem->click();
-    $selfmock->redefine('get_property',sub { 1 });
+    $selfmock->mock('get_property',sub { 1 });
 
     $ret = $elem->is_selected();
     is($ret, 1, 'Checkbox is selected');

+ 1 - 1
t/10-switch-to-window.t

@@ -20,7 +20,7 @@ $Selenium::Remote::Driver::FORCE_WD2 = 1;
 
 my @sessions = qw{897bfa82-0f28-4875-8544-5cc02e8b82f6};
 my $mock = Test::MockModule->new('Selenium::Remote::Driver');
-$mock->redefine('new_session', sub { my $s = shift; $s->{session_id} = shift @sessions } );
+$mock->mock('new_session', sub { my $s = shift; $s->{session_id} = shift @sessions } );
 
 foreach (@browsers) {
     my %selenium_args = (

+ 1 - 1
t/12-reuse-session.t

@@ -22,7 +22,7 @@ foreach (@browsers) {
     my @mock_session_ids = qw{2257c1cf-17d9-401a-a13b-fc7a279d7db5 dddddddd-17d9-401a-a13b-fc7a279d7db5 17c83f3a-3f23-4ffc-a50f-06ba5f5202d1};
 
     my $mock = Test::MockModule->new('Selenium::Remote::Driver');
-    $mock->redefine('new_session', sub { my $s = shift; $s->{session_id} //= shift @mock_session_ids } );
+    $mock->mock('new_session', sub { my $s = shift; $s->{session_id} //= shift @mock_session_ids } );
 
 
     my %selenium_args = (

+ 1 - 1
t/Test-Selenium-Remote-Driver-google.t

@@ -20,7 +20,7 @@ my %selenium_args = %{ $harness->base_caps };
 
 use Carp::Always;
 my $selfmock = Test::MockModule->new('Selenium::Remote::Driver');
-$selfmock->redefine('new_session', sub { my $self = shift; $self->{session_id} = "58aff7be-e46c-42c0-ae5e-571ea1c1f466"  });
+$selfmock->mock('new_session', sub { my $self = shift; $self->{session_id} = "58aff7be-e46c-42c0-ae5e-571ea1c1f466"  });
 
 # Try to find
 my $t = Test::Selenium::Remote::Driver->new(