Forráskód Böngészése

Add maximize() polyfill for chrome

George S. Baugh 8 éve
szülő
commit
8c7e0ee463
2 módosított fájl, 5 hozzáadás és 2 törlés
  1. 2 2
      at/sanity-chrome.test
  2. 3 0
      lib/Selenium/Remote/Driver.pm

+ 2 - 2
at/sanity-chrome.test

@@ -136,9 +136,9 @@ ok($driver->switch_to_frame(),"can switch to parent frame (WD3 only)");
 ok($driver->set_window_position(1,1),"can set window position (WD3)");
 ok($driver->set_window_size(200,200),"can set window size (WD3)");
 
+ok($driver->maximize_window(),"can maximize window (WD3)");
 SKIP: {
-    skip "chromedriver does not maximize/minimize", 2;
-    ok($driver->maximize_window(),"can maximize window (WD3)");
+    skip "chromedriver does not minimize", 1;
     ok($driver->minimize_window(),"can minimize window (WD3 only)");
 }
 ok($driver->fullscreen_window(),"can fullscreen window (WD3 only)");

+ 3 - 0
lib/Selenium/Remote/Driver.pm

@@ -2241,6 +2241,9 @@ sub set_window_size {
 
 sub maximize_window {
     my ( $self, $window ) = @_;
+    if ($self->{is_wd3} && $self->browser_name eq 'chrome') {
+        return $self->execute_script(qq{window.resizeTo(screen.availWidth,screen.availHeight); return 1;});
+    }
     $window = ( defined $window ) ? $window : 'current';
     my $res = { 'command' => 'maximizeWindow', 'window_handle' => $window };
     my $ret = $self->_execute_command( $res );