Selaa lähdekoodia

Revert "Fix #135 : catch the new responses from Selenium 2.42"

This reverts f22f548 and 5d11c36. As discussed in #145, this solution
does not work as it interferes with some endpoints that expect to be
able to return false by indicating "" as their return value.

These fixes would catch that "" and return a non-empty string, which
would in turn evaluate to true.

Conflicts:
        lib/Selenium/Remote/RemoteConnection.pm
Daniel Gempesaw 11 vuotta sitten
vanhempi
sitoutus
a0309600f4
1 muutettua tiedostoa jossa 1 lisäystä ja 1 poistoa
  1. 1 1
      lib/Selenium/Remote/RemoteConnection.pm

+ 1 - 1
lib/Selenium/Remote/RemoteConnection.pm

@@ -131,7 +131,7 @@ sub _process_response {
         }
         elsif ($response->is_success) {
             $data->{'cmd_status'} = 'OK';
-            if (defined $decoded_json && defined $decoded_json->{'value'}) {
+            if (defined $decoded_json) {
                 $data->{'cmd_return'} = $decoded_json->{'value'};
             }
             else {