George S. Baugh 5 years ago
parent
commit
b0a1e8db3f
3 changed files with 7 additions and 3 deletions
  1. 4 0
      Changes
  2. 1 1
      dist.ini
  3. 2 2
      lib/Selenium/CanStartBinary.pm

+ 4 - 0
Changes

@@ -1,5 +1,9 @@
 Revision history for Selenium-Remote-Driver
 
+1.37  02-17-2019 TEODESIAN
+        [BUG FIXES]
+        - obey the auto_close flag in the direct drivers
+
 1.36  10-21-2019 TEODESIAN
         [BUG FIXES]
         - Adjust handling of chrome due to it implementing WC3 mostly correctly now

+ 1 - 1
dist.ini

@@ -1,5 +1,5 @@
 name = Selenium-Remote-Driver
-version = 1.36
+version = 1.37
 author = George S. Baugh <george@troglodyne.net>
 author = Aditya Ivaturi <ivaturi@gmail.com>
 author = Daniel Gempesaw <gempesaw@gmail.com>

+ 2 - 2
lib/Selenium/CanStartBinary.pm

@@ -410,10 +410,10 @@ sub _handle_firefox_setup {
 sub shutdown_binary {
     my ($self) = @_;
 
-    if ( $self->auto_close && defined $self->session_id ) {
+    return unless $self->auto_close();
+    if ( defined $self->session_id ) {
         $self->quit();
     }
-
     if ( $self->has_binary_mode && $self->binary_mode ) {
 
         # Tell the binary itself to shutdown