Merge pull request #212 from gempesaw/fix-find-no-elt-ok

Fix find no elt ok

lib/Test/Selenium/Remote/Driver.pm

@@ -375,9 +375,9 @@ sub element_value_is {
     return $self->_find_element_with_action( $method, @_ );
 }
 
-=head2 $twd->click_element_ok($search_target [,$desc]);
+=head2 $twd->click_element_ok($search_target [,$finder ,$desc]);
 
-    $twd->click_element_ok($search_target [,$desc]);
+    $twd->click_element_ok($search_target [,$finder ,$desc]);
 
 Find an element and then click on it.
 
@@ -389,9 +389,9 @@ sub click_element_ok {
     return $self->_find_element_with_action( $method, @_ );
 }
 
-=head2 $twd->clear_element_ok($search_target [,$desc]);
+=head2 $twd->clear_element_ok($search_target [,$finder ,$desc]);
 
-    $twd->clear_element_ok($search_target [,$desc]);
+    $twd->clear_element_ok($search_target [,$finder ,$desc]);
 
 Find an element and then clear on it.
 
@@ -403,9 +403,9 @@ sub clear_element_ok {
     return $self->_find_element_with_action( $method, @_ );
 }
 
-=head2 $twd->is_element_displayed_ok($search_target [,$desc]);
+=head2 $twd->is_element_displayed_ok($search_target [,$finder ,$desc]);
 
-    $twd->is_element_displayed_ok($search_target [,$desc]);
+    $twd->is_element_displayed_ok($search_target [,$finder ,$desc]);
 
 Find an element and check to confirm that it is displayed. (visible)
 
@@ -417,9 +417,9 @@ sub is_element_displayed_ok {
     return $self->_find_element_with_action( $method, @_ );
 }
 
-=head2 $twd->is_element_enabled_ok($search_target [,$desc]);
+=head2 $twd->is_element_enabled_ok($search_target [,$finder ,$desc]);
 
-    $twd->is_element_enabled_ok($search_target [,$desc]);
+    $twd->is_element_enabled_ok($search_target [,$finder ,$desc]);
 
 Find an element and check to confirm that it is enabled.
 
@@ -450,8 +450,7 @@ See there for more details on the format for C<find_element_ok()>.
 
 Returns true if C<$search_target> is I<not> found on the page. C<$search_target>
 is passed to L<Selenium::Remote::Driver/find_element> using a finder or the
-C<default_finder> if none passed.See there for more details on the format. 
-for C<find_no_element_ok()>.
+C<default_finder> if none passed. See there for more details on the format for C<find_no_element_ok()>.
 
 =cut
 

lib/Test/Selenium/Remote/Role/DoesTesting.pm

@@ -5,6 +5,7 @@ package Test::Selenium::Remote::Role::DoesTesting;
 use Moo::Role;
 use Test::Builder;
 use Try::Tiny;
+use Scalar::Util 'blessed';
 use List::MoreUtils qw/any/;
 use namespace::clean;
 
@@ -96,11 +97,19 @@ sub _check_ok {
         }
     };
 
+
     my $default_test_name = $method;
     $default_test_name .= "'" . join("' ", @r_args) . "'"
         if $num_of_args > 0;
 
     my $test_name = pop @args // $default_test_name;
+
+    # case when find_no_element found an element, we should croak
+    if ($real_method eq 'find_no_element') { 
+        if (blessed($rv) && $rv->isa('Selenium::Remote::WebElement')) { 
+            $self->croak($test_name);
+        }
+    }
     return $self->ok( $rv, $test_name);
 }
 

t/Test-Selenium-Remote-Driver.t

@@ -113,6 +113,7 @@ ok( exception { $successful_driver->find_child_element_ok({id => 1200}) }, 'find
 # find no element ok test
 
 $successful_driver->find_no_element_ok('notq','xpath','find_no_element_ok works');
+ok(exception { $successful_driver->find_no_element_ok('q','xpath','find_no_element_ok works') }, 'find no element dies when an element is found');
 
 # body and content function family
 $successful_driver->content_like( qr/matches/, 'content_like works');