Эхлэл Бүгдийг харах Тусламж
Нэвтрэх
teo
/
Selenium-Remote-Driver
-с салаалсан Troglodyne/Selenium-Remote-Driver
1
0
Салаа 0
Файлууд
Эх сурвалжийг харах

Don't check for html to see if the server returned an error, check content type

If the server didn't return JSON it's some sort of error, but we should not
assume that it's HTML. Sauce Labs just returns a simple text message. The code
as it was previously would look for <html>, not find it, and then blow up when
it tried to treat the text message as JSON.
Dave Rolsky 12 жил өмнө
parent
505232ba43
commit
f04292987a
1 өөрчлөгдсөн 1 нэмэгдсэн , 1 устгасан
Өөрчлөлтийг ялгаж харах Өөрчлөлтийн статистик харах
  1. 1 1
      lib/Selenium/Remote/RemoteConnection.pm

+ 1 - 1
lib/Selenium/Remote/RemoteConnection.pm
Файл харах 

@@ -92,7 +92,7 @@ sub _process_response {
 
         my $decoded_json = undef;
 
         print "RES: ".$response->decoded_content."\n\n" if $self->{debug};
 
         if (($response->message ne 'No Content') && ($response->content ne '')) {
 
-            if ($response->content =~ m/^<html>/i) {
 
+            if ($response->content_type !~ m/json/i) {
 
                 $data->{'cmd_return'} = 'Server returned error message '.$response->content.' instead of data';
 
                 return $data;
 
             }