Inicio Explorar Axuda
Iniciar sesión
teo
/
Selenium-Remote-Driver
Fork de Troglodyne/Selenium-Remote-Driver
1
0
Fork 0
Ficheiros
Explorar o código

Don't check for html to see if the server returned an error, check content type

If the server didn't return JSON it's some sort of error, but we should not
assume that it's HTML. Sauce Labs just returns a simple text message. The code
as it was previously would look for <html>, not find it, and then blow up when
it tried to treat the text message as JSON.
Dave Rolsky %!s(int64=12) %!d(string=hai) anos
pai
505232ba43
achega
f04292987a
Modificáronse 1 ficheiros con 1 adicións e 1 borrados
Unificar vista Mostrar estatísticas de Diff
  1. 1 1
      lib/Selenium/Remote/RemoteConnection.pm

+ 1 - 1
lib/Selenium/Remote/RemoteConnection.pm
Ver ficheiro 

@@ -92,7 +92,7 @@ sub _process_response {
 
         my $decoded_json = undef;
 
         my $decoded_json = undef;
 
         print "RES: ".$response->decoded_content."\n\n" if $self->{debug};
 
         print "RES: ".$response->decoded_content."\n\n" if $self->{debug};
 
         if (($response->message ne 'No Content') && ($response->content ne '')) {
 
         if (($response->message ne 'No Content') && ($response->content ne '')) {
 
-            if ($response->content =~ m/^<html>/i) {
 
+            if ($response->content_type !~ m/json/i) {
 
                 $data->{'cmd_return'} = 'Server returned error message '.$response->content.' instead of data';
 
                 $data->{'cmd_return'} = 'Server returned error message '.$response->content.' instead of data';
 
                 return $data;
 
                 return $data;
 
             }
 
             }